Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disablePan does not work on runtime #439

Closed
haseebahmad109 opened this issue Jan 10, 2020 · 2 comments
Closed

disablePan does not work on runtime #439

haseebahmad109 opened this issue Jan 10, 2020 · 2 comments
Labels
bug released

Comments

@haseebahmad109
Copy link

When we set the "disablePan" option using setOptions function it does not enable/disable the pan functionality.

I think we should be able to change it dynamically if we want to allow pan functionality via external control/button.
@timmywil
Copy link
Owner

Thanks for opening an issue. I completely agree. I've added a patch to master that binds and unbinds events when the disablePan option changes.

@timmywil timmywil added the bug label Jan 13, 2020
timmywil added a commit that referenced this issue Jan 13, 2020
@timmywil
chore(release): 4.0.1 [skip ci]
64ae190 
## [4.0.1](4.0.0...4.0.1) (2020-01-13)

### Bug Fixes

* **reset:** ignore disable and panOnlyWhenZoomed options ([47f9e1b](47f9e1b)), closes [#434](#434)
* **setoptions:** bind/destroy depending on disablePan option ([a773e2e](a773e2e)), closes [#439](#439)
timmywil added a commit that referenced this issue Jan 13, 2020
@timmywil
chore(release): 4.0.1 [skip ci]
0492ce7 
## [4.0.1](4.0.0...4.0.1) (2020-01-13)

### Bug Fixes

* **reset:** ignore disable and panOnlyWhenZoomed options ([47f9e1b](47f9e1b)), closes [#434](#434)
* **setoptions:** bind/destroy depending on disablePan option ([a773e2e](a773e2e)), closes [#439](#439)
@timmywil
Copy link
Owner

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timmywil @haseebahmad109