chore: Update wrong case for rules

Signed-off-by: Timon Wong <[email protected]>
timonwong · Aug 29, 2022 · 20319dc · 20319dc
1 parent f799a59
commit 20319dc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/flags_test.go b/flags_test.go
@@ -29,13 +29,24 @@ func TestIgnoredLoggerFlag(t *testing.T) {
 	assert.ErrorContains(t, err, "-ignoredloggers: unknown logger: \"unknownlogger\"")
 }
 
+func TestNoRuleFile(t *testing.T) {
+	f := ruleFileFlag{}
+
+	fs := flag.NewFlagSet("test", flag.ContinueOnError)
+	fs.SetOutput(io.Discard)
+	fs.Var(&f, "rulefile", "")
+
+	err := fs.Parse([]string{"-rulefile=testdata/xxx-not-exists-xxx.txt"})
+	assert.ErrorContains(t, err, "open testdata/xxx-not-exists-xxx.txt: no such file or directory")
+}
+
 func TestWrongRuleFile(t *testing.T) {
 	f := ruleFileFlag{}
 
 	fs := flag.NewFlagSet("test", flag.ContinueOnError)
 	fs.SetOutput(io.Discard)
 	fs.Var(&f, "rulefile", "")
 
-	err := fs.Parse([]string{"-rulefile=testdata/xxx-not-exists-xxx.yaml"})
-	assert.ErrorContains(t, err, "open testdata/xxx-not-exists-xxx.yaml: no such file or directory")
+	err := fs.Parse([]string{"-rulefile=testdata/wrong-rules.txt"})
+	assert.ErrorContains(t, err, "error parse rule at line 2: invalid rule format")
 }
diff --git a/rules/rules.go b/rules/rules.go
@@ -12,7 +12,7 @@ import (
 	"github.com/timonwong/loggercheck/internal/bytebufferpool"
 )
 
-var ErrInvalidRule = errors.New("invalid rule")
+var ErrInvalidRule = errors.New("invalid rule format")
 
 type RulesetList []Ruleset
 

diff --git a/checker.go → staticrules.go b/checker.go → staticrules.go
diff --git a/testdata/wrong-rules.txt b/testdata/wrong-rules.txt
@@ -0,0 +1,2 @@
+# Wrong rule file
+(*a/wrong.Method.Rule