PR/issue review queue

[timotheecour]

post-merge

• config system: special case -d:release and -d:danger [backport:1.4] by Araq · Pull Request #18051 · nim-lang/Nim
• Fixes #5034 illformed AST from getImpl with proc returning value by DylanModesitt · Pull Request #17976 · nim-lang/Nim
• make strict funcs analysis smarter by Araq · Pull Request #18219 · nim-lang/Nim
• view types: spec changes by Araq · Pull Request #18226 · nim-lang/Nim

post-merge that need revisiting

• hashes for refs should be an opt-in feature by narimiran · Pull Request #18098 · nim-lang/Nim
• Revert "fix #14873 properly by skipping abi field in importc type" by Araq · Pull Request #17992 · nim-lang/Nim
• [std/re] fix findBounds and find procs by xflywind · Pull Request #18028 · nim-lang/Nim
• change mimedb store stringtable to orderedtable by bung87 · Pull Request #18065 · nim-lang/Nim (cast(nosideEffect) problematic)
• system/excpt: check if the exception is not nil before pop by alaviss · Pull Request #18247 · nim-lang/Nim

misc

• destructor for seq[T] elements not called with gc:refc upon setLen 0 · Issue #17186 · nim-lang/Nim

• standardize all stringification API's around allocation-free binary $ operator + variadic strAppend · Issue #191 · nim-lang/RFCs

• Add Week-Of-Year Implementation to Times Module by capocasa · Pull Request #17223 · nim-lang/Nim

• properly fix #10053 (more informative FieldError msg): report discriminant value + lineinfo; also improve for VM case by timotheecour · Pull Request #11955 · nim-lang/Nim

• Improve overload resolution for untyped in generics and templates · Issue #346 · nim-lang/RFCs

• RFC: untyped(expr) for untyped params in overloaded routines · Issue #630 · timotheecour/Nim

• syntax request: from std/[foo1,foo2] import nil ; from "." / [foo1,foo2] import bar1, bar2, bar3 · Issue #76 · nim-lang/RFCs

• New channels implementation for ORC by xflywind · Pull Request #17305 · nim-lang/Nim
  (eg: New channels implementation for ORC nim-lang/Nim#17305 (comment) std/dequeues with max capacity)

• Replace 'cstderr.rawWrite' with 'writeToStdErr' by ehmry · Pull Request #17288 · nim-lang/Nim => can it use same approach as i used in --stacktracemsgs ?

• Arc now bootstraps by Clyybber · Pull Request #17342 · nim-lang/Nim
  => double check: does arc support shallowCopy? and can we instead use byAddr ?

• asyncdispatch+stackTraceOverride: fix premature garbage collection by stefantalpalaru · Pull Request #18039 · nim-lang/Nim

generics

• fixes #11225; generic sandwich problems; [backport:1.2] by Araq · Pull Request #17255 · nim-lang/Nim

• for loop invoked from generic procedure defined in another module cant find items iterator · Issue #11167 · nim-lang/Nim

toOpenArray

• toOpenArray doesn't work in VM; toOpenArray with var openArray doesn't work in nim js · Issue #15952 · nim-lang/Nim
• vm cstring should behave like c cstring · Issue #619 · timotheecour/Nim
• array literals uses typed arrays; fix a jsgen bug by xflywind · Pull Request #16850 · nim-lang/Nim

parse hex

• No checking when a hexadecimal integer constant is too large for its type · Issue #4350 · nim-lang/Nim
• parseHexInt doesn't check the value's length. · Issue #17208 · nim-lang/Nim

RST

• rst: rst2html and doc now have clickable anchors for each paragraph/list element by timotheecour · Pull Request #17251 · nim-lang/Nim

COW

• document copy on write behavior of string literals in arc/orc by xflywind · Pull Request #17224 · nim-lang/Nim
• WIP let a {.rom.} = constExpr · Issue #553 · timotheecour/Nim
• fixes #17173 by Araq · Pull Request #17213 · nim-lang/Nim

enum

• nonpure enum can hijack pure enum; instead should give Error: ambiguous identifier ; pure and nonpure should both mean the same thing; pure should be deprecated · Issue #8850 · nim-lang/Nim
• Pure enums allow using the same name but allow nonqualification with quirky behaviour · Issue #8066 · nim-lang/Nim
  Pragma {.pure.} for "enum" no longer taken in account by the compiler · Issue #12893 · nim-lang/Nim
• regression: {.pure.} pragma fails to hide enum · Issue #16462 · nim-lang/Nim

concepts

• Converter + concept results in an endless (or very long) compiler loop. · Issue #8197 · nim-lang/Nim

perf

• see why C faster than nim here: gccontent-benchmark/gc.c at master · samuell/gccontent-benchmark
• [performance] performance tricks to improve std/json, parsers, lookups · Issue #188 · nim-lang/RFCs
• add nim bitwise by mflevine · Pull Request #22 · samuell/gccontent-benchmark
• Performance - Crystal
• optimizing nim code for performance · timotheecour/vitanim Wiki
• Non-optimal C code generated for (if cond: X else: Y) expression. · Issue #4132 · nim-lang/Nim

compiler flags

• Provide an alternative format for error/warning messages; eg: file:line:col instead of file(line, col) · Issue #690 · nim-lang/Nim

C++

• Use value-initialization in C++ to gracefully handle non-POD types by jwollen · Pull Request #9603 · nim-lang/Nim

my PRs

• rst: rst2html and doc now have clickable anchors for each paragraph/list element by timotheecour · Pull Request #17251 · nim-lang/Nim

• can iterators be implemented as a library solution / syntax sugar over regular procs? · Issue #272 · nim-lang/RFCs

VM

• add test case from VM: support importc var, ptr/pointer types, cast int <=> ptr/pointer nim-lang/Nim#12877
  see https://github.com/timotheecour/vitanim/blob/master/testcases/tests/test_vm_var_importc.nim which contains instructions to build, and shows the different features from this PR
• simplify some logic by adding nkPtrLit node kind

upcoming PR for nim r -b:js --browser main

• see if i can also use libfswatch along with livereload
• hotcodereloading and libfswatch - Nim forum
• Today I Realized that to live reload my Lisp web app is straightforward and so convenient - Lisp journey

outside

• new channels article by xflywind · Pull Request #274 · nim-lang/website

CI failures

• CI fails: The repository 'dl.bintray.com/sbt/debian Release' no longer has a Release file. · Issue #652 · timotheecour/Nim
• CI fails: curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to homebrew.bintray.com:443 · Issue #653 · timotheecour/Nim
• CI fails on azure 32 bit linux Linux_i386: sudo apt-fast install fails · Issue #17325 · nim-lang/Nim
• refs #17325 linux 32 by timotheecour · Pull Request #17359 · nim-lang/Nim
• Pr fix 17325 linux32 alt docker by timotheecour · Pull Request #654 · timotheecour/Nim

---

done

• Add module jsfetch by juancarlospaco · Pull Request #12531 · nim-lang/Nim

• fix RST parsing when no indent after enum.item (fix #17249) by a-mr · Pull Request #17257 · nim-lang/Nim

• iterable[T] by timotheecour · Pull Request #17196 · nim-lang/Nim

• import foo {.all.} by timotheecour · Pull Request #11865 · nim-lang/Nim

• close #11330 sets uses optimized countSetBits by xflywind · Pull Request #17334 · nim-lang/Nim

• add algorithm.merge by xflywind · Pull Request #16182 · nim-lang/Nim

• unify tuple expressions by krux02 · Pull Request #13793 · nim-lang/Nim

• [WIP] Adding support for user-defined number suffixes by JohnAD · Pull Request #17020 · nim-lang/Nim

• fidget useHead=false fidget breaks nim CI again · Issue #133 · treeform/fidget