New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #17173 #17213

Merged

Araq merged 10 commits into devel from araq-prepare-mutation

Mar 1, 2021

Member

Araq commented Mar 1, 2021 •

edited by timotheecour

Loading

fixes #17173

Todo:

Documentation for prepareStrMutation
Add the test case.

Follow up

Documentation of ORC's COW strings

Araq and others added 3 commits

March 1, 2021 11:32


          fixes #17173

f7198ea


          Merge branch 'devel' into araq-prepare-mutation

a7aa0da


          add testcase (#17214)

6231d86

ringabout reviewed

View reviewed changes

changelog.md Outdated Show resolved Hide resolved

ringabout reviewed

View reviewed changes

lib/system.nim Outdated Show resolved Hide resolved

ringabout self-assigned this

ringabout mentioned this pull request

My todo list ringabout/todo#6

Open

11 tasks

ringabout reviewed

View reviewed changes

lib/system/strs_v2.nim Show resolved Hide resolved

ringabout reviewed

View reviewed changes

lib/system.nim Outdated Show resolved Hide resolved


          Apply suggestions from code review

94ab8c6

ringabout reviewed

View reviewed changes

lib/std/strbasics.nim Outdated Show resolved Hide resolved


          fix for newruntime

350c6a1

ringabout reviewed

View reviewed changes

tests/arc/t17173.nim Outdated Show resolved Hide resolved


          Apply suggestions from code review

d70e6c4

ringabout reviewed

View reviewed changes

lib/system.nim Outdated Show resolved Hide resolved


          Update lib/system.nim

cf3ccae

ringabout added the TODO: followup needed label

ringabout reviewed

View reviewed changes

lib/system.nim Outdated Show resolved Hide resolved


          Update lib/system.nim

e429836

ghost reviewed

View reviewed changes

lib/system.nim Outdated Show resolved Hide resolved

ringabout and others added 2 commits

March 1, 2021 22:30


          Update lib/system.nim

6f0ceae

Co-authored-by: Danil Yarantsev <[email protected]>


          Merge branch 'devel' into araq-prepare-mutation

Member Author

Araq commented Mar 1, 2021

Unrelated CI failure, merging.

Araq merged commit bb0c19f into devel

Araq deleted the araq-prepare-mutation branch

March 1, 2021 19:58

ringabout removed the TODO: followup needed label

This was referenced Mar 2, 2021

document copy on write behavior of string literals in arc/orc #17224

Merged

add runnableExamples for prepareStrMutation #17227

Merged

This was referenced Mar 6, 2021

WIP let a {.rom.} = constExpr timotheecour/Nim#553

Open

PR/issue review queue timotheecour/Nim#641

Open

ringabout added a commit to ringabout/Nim that referenced this pull request


          fixes nim-lang#17173 (nim-lang#17213)

1c6e81e

* fixes nim-lang#17173

* add testcase (nim-lang#17214)

* Apply suggestions from code review

* fix for newruntime

* Apply suggestions from code review

* Update lib/system.nim

* Update lib/system.nim

* Update lib/system.nim

Co-authored-by: Danil Yarantsev <[email protected]>

Co-authored-by: flywind <[email protected]>
Co-authored-by: Danil Yarantsev <[email protected]>

ardek66 pushed a commit to ardek66/Nim that referenced this pull request


          fixes nim-lang#17173 (nim-lang#17213)

f75917f

* fixes nim-lang#17173

* add testcase (nim-lang#17214)

* Apply suggestions from code review

* fix for newruntime

* Apply suggestions from code review

* Update lib/system.nim

* Update lib/system.nim

* Update lib/system.nim

Co-authored-by: Danil Yarantsev <[email protected]>

Co-authored-by: flywind <[email protected]>
Co-authored-by: Danil Yarantsev <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet