Allow creation of shared library for libTink #1
Conversation
| URL https://github.com/Tencent/rapidjson/archive/v1.1.0.tar.gz | ||
| SHA256 bf7ced29704a1e696fbccf2a2b4ea068e7774fa37f6d7dd4039d0787f8bed98e | ||
| ) | ||
| endif() | ||
| # Rapidjson is a header-only library with no explicit target. Here we create one. | ||
| add_library(rapidjson INTERFACE) | ||
| target_include_directories(rapidjson INTERFACE "${rapidjson_SOURCE_DIR}") |
There was a problem hiding this comment.
How is this variable populated when TINK_USE_INSTALLED_RAPIDJSON=ON?
| @@ -110,7 +110,7 @@ if (NOT TARGET crypto) | |||
| "$<BUILD_INTERFACE:${boringssl_SOURCE_DIR}/src/include>") | |||
| else() | |||
| # Support for ED25519 was added from 1.1.1. | |||
| find_package(OpenSSL 1.1.1 REQUIRED) | |||
There was a problem hiding this comment.
Leaving 1.1.1 here provides a lower bound for OpenSSL which is what we want. I my understanding correct?
| tink_cc_library( | ||
| NAME cc | ||
| SRCS | ||
| set(TINK_PUBLIC_APIS |
| ${TINK_PUBLIC_APIS} | ||
| DEPS | ||
| ${TINK_PUBLIC_API_DEPS} | ||
| PUBLIC |
There was a problem hiding this comment.
nit: PUBLIC should be aligned with DEPS
| target_link_libraries(tink | ||
| PRIVATE | ||
| -Wl,--whole-archive | ||
| ${TINK_PUBLIC_API_DEPS} |
There was a problem hiding this comment.
If we do this, would the tink target include (and export) absl?
This commit enable to cross compile the libTink by creating a shared library. Signed-off-by: Muhammad Usama <[email protected]>
|
@chaudhryusama @morambro I have cloned this: https://github.com/chaudhryusama/tink-cc My Cmake command: Platform: macOS 14.2 MacBook Pro |
This commit enable to cross compile the libTink by creating a shared library.