Skip to content

inverse_transform in TimeSeriesImputerTransform #132

Closed
3 tasks done
julia-shenshina opened this issue Oct 5, 2021 · 0 comments · Fixed by #135
Closed
3 tasks done

inverse_transform in TimeSeriesImputerTransform #132

julia-shenshina opened this issue Oct 5, 2021 · 0 comments · Fixed by #135
Assignees
Labels
enhancement New feature or request

Comments

@julia-shenshina
Copy link
Contributor

🚀 Feature Request

Add inverse_transform methods for TimeSeriesImputerTransform

Motivation

In case of inplace transformation we expect smth like inverse_transform(transform(x)) == x.

Proposal

Save list of missing values on fit_transform stage, replace the corresponding timestamps with None in inverse_transform

Test cases

For TimeSeriesImputerTransform add tests that check inverse_transform(transform(x)) == x + check that inverse_transform(future_x) == future_x

Alternatives

No response

Additional context

No response

Checklist

  • Added feature request
  • Added motivation
  • Added proposal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants