Skip to content

Add inverse_transform in TimeSeriesImputerTransform #135

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Oct 5, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

  • Add inverse_transform in TimeSeriesImputerTransform along with tests
  • Little refactor of test_impute_transform.py
  • Fix bug with inplace transform with option running_mean

Related Issue

#132.

Closing issues

Closes #132.

@Mr-Geekman Mr-Geekman added bug Something isn't working enhancement New feature or request labels Oct 5, 2021
@Mr-Geekman Mr-Geekman self-assigned this Oct 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #135 (362c666) into master (d4b98a4) will decrease coverage by 1.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   88.06%   87.01%   -1.05%     
==========================================
  Files          66       66              
  Lines        2865     2873       +8     
==========================================
- Hits         2523     2500      -23     
- Misses        342      373      +31     
Impacted Files Coverage Δ
etna/transforms/imputation.py 100.00% <100.00%> (ø)
etna/models/nn/deepar.py 73.91% <0.00%> (-26.09%) ⬇️
etna/models/nn/tft.py 75.00% <0.00%> (-25.00%) ⬇️
etna/transforms/pytorch_forecasting.py 92.20% <0.00%> (-7.80%) ⬇️
etna/loggers/base.py 92.30% <0.00%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b98a4...362c666. Read the comment docs.

Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Mr-Geekman Mr-Geekman marked this pull request as ready for review October 5, 2021 13:35
@julia-shenshina julia-shenshina merged commit 84fbd7d into master Oct 5, 2021
@iKintosh iKintosh deleted the issue-132 branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inverse_transform in TimeSeriesImputerTransform
3 participants