Skip to content

plot_forecast should work without test_ts #314

Closed
1 task done
iKintosh opened this issue Nov 25, 2021 · 0 comments · Fixed by #321
Closed
1 task done

plot_forecast should work without test_ts #314

iKintosh opened this issue Nov 25, 2021 · 0 comments · Fixed by #321
Assignees
Labels
invalid This doesn't seem right

Comments

@iKintosh
Copy link
Contributor

🐛 Bug Report

Now plot_forecast requires test_ts argument. But sometimes I want to plot only train data and forecast. So we should make test_ts argument optional.

Expected behavior

User should be able to plot only forecast, forecast + train_ts, forecast + test_ts and forecast + train_ts + test_ts.

How To Reproduce

Code

def plot_forecast(
forecast_ts: "TSDataset",
test_ts: "TSDataset",
train_ts: Optional["TSDataset"] = None,
segments: Optional[List[str]] = None,
n_train_samples: Optional[int] = None,
columns_num: int = 2,
):

Environment

Any, etna 1.3.3

Additional context

No response

Checklist

  • Bug appears at the latest library version
@iKintosh iKintosh added the invalid This doesn't seem right label Nov 25, 2021
@Mr-Geekman Mr-Geekman self-assigned this Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants