Skip to content

Make test_ts optional in plot_forecast #321

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Make test_ts optional in plot_forecast #321

merged 3 commits into from
Nov 29, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Nov 29, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look at #314.

Related Issue

#314.

Closing issues

Closes #314.

@Mr-Geekman Mr-Geekman self-assigned this Nov 29, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review November 29, 2021 07:57
@codecov-commenter
Copy link

Codecov Report

Merging #321 (bf72243) into master (a764443) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   54.42%   54.38%   -0.05%     
==========================================
  Files          97       97              
  Lines        4777     4781       +4     
==========================================
  Hits         2600     2600              
- Misses       2177     2181       +4     
Impacted Files Coverage Δ
etna/analysis/plotters.py 12.16% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a764443...bf72243. Read the comment docs.

@julia-shenshina julia-shenshina merged commit 40e7060 into master Nov 29, 2021
@iKintosh iKintosh deleted the issue-314 branch December 9, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_forecast should work without test_ts
3 participants