Skip to content

Unpin pytorch-forecasting dependency on specific version #387

Closed
1 task
martins0n opened this issue Dec 16, 2021 · 1 comment · Fixed by #445
Closed
1 task

Unpin pytorch-forecasting dependency on specific version #387

martins0n opened this issue Dec 16, 2021 · 1 comment · Fixed by #445
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@martins0n
Copy link
Contributor

🚀 Feature Request

Currently we pin specific version of pytorch-forecasting (0.8.5 to be exact).
Probably we should specify only minimum and maximum versions

Motivation

Library installation in existing environments would cause less dependency problems.

Proposal

  • Check new releases of pytorch-forecasting for api updates and bug fixes
  • If there's no radical changes it seems we can unpeen version

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@alex-hse-repository
Copy link
Collaborator

  1. The next version after 0.8.5 is 0.9.0. which changes the API see. Both changes influence PytorchForecastingTransform constructor. So, as I understand, we can only use 0.8.5 or ^0.9.0 with changing the PytorchForecastingTransform constructor
  2. In addition since 0.9.1 python ^3.7.1 is required, when we have ">=3.7.0, <3.10.0"
  3. Also, since 0.9.1 pandas ^1.3.0 is required

Create a draft with changes for ^0.9.0 versions

@martins0n martins0n added this to the etna 1.6.0 milestone Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants