Skip to content

Add upadate sklearn, python and pytorch-forecasting versions #445

Merged
merged 7 commits into from
Jan 13, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #387

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Jan 11, 2022
@alex-hse-repository alex-hse-repository self-assigned this Jan 11, 2022
@alex-hse-repository alex-hse-repository marked this pull request as draft January 11, 2022 14:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #445 (dd4b0a4) into master (cf95197) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   87.64%   87.63%   -0.01%     
==========================================
  Files         112      112              
  Lines        5276     5275       -1     
==========================================
- Hits         4624     4623       -1     
  Misses        652      652              
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 89.86% <ø> (ø)
etna/ensembles/stacking_ensemble.py 98.30% <ø> (ø)
etna/transforms/nn/pytorch_forecasting.py 95.23% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf95197...dd4b0a4. Read the comment docs.

@martins0n martins0n marked this pull request as ready for review January 13, 2022 16:47
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n enabled auto-merge (squash) January 13, 2022 16:48
@martins0n martins0n merged commit 5b0f1f1 into master Jan 13, 2022
@martins0n martins0n deleted the sklearn_version branch January 13, 2022 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin pytorch-forecasting dependency on specific version
3 participants