We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Both should inherit from PerSegmentPredictionIntervalModel.
PerSegmentPredictionIntervalModel
Make final changes for PredictionIntervalModels
ProphetModel
SARIMAXModel
forecast
forecast_one_segment
_ProphetModel
_ProphetAdapter
_SARIMAXModel
_SARIMAXAdapter
Change this line, it should check isinstance, not signature.
etna/etna/pipeline/pipeline.py
Line 156 in 1a10b25
Remove unnecessary methods and parameters from PerSegmentBaseModel:
_build_models
_segments
No response
Blocked by #506, #508
The text was updated successfully, but these errors were encountered:
PerSegmentBaseModel
PerSegmentModel
alex-hse-repository
Successfully merging a pull request may close this issue.
🚀 Feature Request
Both should inherit from
PerSegmentPredictionIntervalModel
.Motivation
Make final changes for PredictionIntervalModels
Proposal
ProphetModel
, norSARIMAXModel
should implementforecast
andforecast_one_segment
methods after this task._ProphetModel
to_ProphetAdapter
_SARIMAXModel
to_SARIMAXAdapter
forecast
andforecast_one_segment
methods should be moved either to Adapters or PerSegmentPredictionIntervalModelChange this line, it should check isinstance, not signature.
etna/etna/pipeline/pipeline.py
Line 156 in 1a10b25
Remove unnecessary methods and parameters from PerSegmentBaseModel:
_build_models
_segments
Test cases
No response
Alternatives
Blocked by #506, #508
Additional context
No response
Checklist
The text was updated successfully, but these errors were encountered: