Skip to content

Inherit all PerSegment models from PerSegmentModel #508

Closed
1 task done
iKintosh opened this issue Feb 7, 2022 · 0 comments · Fixed by #543
Closed
1 task done

Inherit all PerSegment models from PerSegmentModel #508

iKintosh opened this issue Feb 7, 2022 · 0 comments · Fixed by #543
Assignees
Labels
enhancement New feature or request

Comments

@iKintosh
Copy link
Contributor

iKintosh commented Feb 7, 2022

🚀 Feature Request

All PerSegmentModels that do not implement prediction intervals should be inherited from PerSegmentModel

Motivation

Final step for PerSegmentModel

Proposal

  1. Models below should inherit from PerSegmentModel and should not implement any other methods except _init_:
  • CatBoostPerSegmentModel
  • SklearnPerSegmentModel
  • HoltWintersModel
  1. Rename:
  • _CatBoostModel
  • _SklearnModel
  • _HoltWintersModel
    to:
  • _CatBoostAdapter
  • _SklearnAdapter
  • _HoltWintersAdapter
  1. Change signature fit(self, df: pd.DataFrame, regressors: List[str]) for:
  • _CatBoostAdapter
  • _HoltWintersAdapter
  • _SeasonalMovingAverageModel
  1. Now PerSegmentBaseModel should pass the list of regressors from the dataset to fit of base_model here
  2. Make sure this test passes
  3. Update any necessary tests

Test cases

No response

Alternatives

No response

Additional context

Blocked by #505 #506

Checklist

  • I discussed this issue with ETNA Team
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants