Skip to content

Make DeadlineMovingAverageModel to work with context #907

Closed
Mr-Geekman opened this issue Sep 2, 2022 · 1 comment
Closed

Make DeadlineMovingAverageModel to work with context #907

Mr-Geekman opened this issue Sep 2, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

🚀 Feature Request

We want to teach DeadlineMovingAverageModel to work with context to enable inference mode.

Proposal

  1. Make DeadlineMovingAverageModel the child of NonPredictionIntervalContextRequiredAbstractModel instead of NonPredictionIntervalContextIgnorantAbstractModel.
  2. Change NonPredictionIntervalContextIgnorantModelMixin into NonPredictionIntervalContextRequiredModelMixin.
  3. Fix _DeadlineMovingAverageModel to work with context.
  4. Fix PerSegmentModelMixin to work with prediction size, there probably will be some problems.
  5. Fix tests on test_inference to work with a new type of model.

Test cases

  1. Make sure current tests pass.
  2. Modify tests for DeadlineMovingAverageModel.
  3. Fix test_inference tests.

Additional context

No response

@Mr-Geekman
Copy link
Contributor Author

Solved via #917.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant