Skip to content

Make SeasonalMovingAverageModel and DeadlineMovingAverageModel to work with context #917

Merged
merged 9 commits into from
Sep 6, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 5, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  1. Look at Make SeasonalMovingAverageModel and children to work with context #905.
  2. Look at Make DeadlineMovingAverageModel to work with context #907.

Closing issues

Closes #905.
Closes #907.

@Mr-Geekman Mr-Geekman self-assigned this Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

🚀 Deployed on https://deploy-preview-917--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 5, 2022 12:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 5, 2022 12:42 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (inference@2a207d2). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             inference     #917   +/-   ##
============================================
  Coverage             ?   49.63%           
============================================
  Files                ?      130           
  Lines                ?     7515           
  Branches             ?        0           
============================================
  Hits                 ?     3730           
  Misses               ?     3785           
  Partials             ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request September 5, 2022 12:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 5, 2022 13:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 5, 2022 14:13 Inactive
etna/models/deadline_ma.py Outdated Show resolved Hide resolved
etna/models/deadline_ma.py Outdated Show resolved Hide resolved
tests/test_models/test_simple_models.py Outdated Show resolved Hide resolved
tests/test_models/test_simple_models.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request September 6, 2022 09:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 6, 2022 10:36 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants