Enhance TSDataset to work with hierarchical series
#1048
Conversation
|
🚀 Deployed on https://deploy-preview-1048--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## hierarchical_pipeline #1048 +/- ##
========================================================
Coverage ? 50.96%
========================================================
Files ? 164
Lines ? 8779
Branches ? 0
========================================================
Hits ? 4474
Misses ? 4305
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is there a dedicated method to check if particular |
|
|
||
| df_level = segment_levels.pop() | ||
| level_segments = self.hierarchical_structure.get_level_segments(level_name=df_level) | ||
| if len(df_segments) != len(level_segments): |
There was a problem hiding this comment.
I'm not sure if this check should be here or not.
There was a problem hiding this comment.
Why do you think so? You mean that it is not the real case?
There was a problem hiding this comment.
I don't really think that it should be in exactly this function. Check is useful, but it looks somewhat artificial in this function because we have already got that we wanted here.
There was a problem hiding this comment.
Ok, my problem with this function is what it checks this conditions every run. But according to the name it should just return the value and don't check correctness during each run.
There was a problem hiding this comment.
I'm generally ok with this, it is optional to fix.
You mean check smth like |
I mean how do we properly check if an instance has a hierarchical structure.? Is it |
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #1028