-
Notifications
You must be signed in to change notification settings - Fork 80
Add auto base and auto abstract #1114
Add auto base and auto abstract #1114
Conversation
…GooseIt/etna into add_auto_base_and_auto_abstract Pull changes from master
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1114 +/- ##
===========================================
+ Coverage 68.39% 87.06% +18.66%
===========================================
Files 170 170
Lines 9335 9347 +12
===========================================
+ Hits 6385 8138 +1753
+ Misses 2950 1209 -1741
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at comments above.
I've moved most of |
What about refactoring |
As classes If I am wrong, what the refactored tests should check? |
We have methods You doesn't have to instantiate classes, tests are written using mocks. |
Before submitting (must do checklist)
Proposed Changes
See issue#1023
Closing issues
closes #1023