Skip to content

Decouple SeasonalMovingAverageModel from PerSegmentModelMixin #1132

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Feb 27, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1116.

Closing issues

Closes #1116.

@Mr-Geekman Mr-Geekman self-assigned this Feb 27, 2023
@github-actions
Copy link

github-actions bot commented Feb 27, 2023

@github-actions github-actions bot temporarily deployed to pull request February 27, 2023 11:47 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (inference-v2.1@0b0a96e). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                Coverage Diff                @@
##             inference-v2.1    #1132   +/-   ##
=================================================
  Coverage                  ?   86.90%           
=================================================
  Files                     ?      164           
  Lines                     ?     8975           
  Branches                  ?        0           
=================================================
  Hits                      ?     7800           
  Misses                    ?     1175           
  Partials                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request February 27, 2023 12:34 Inactive
etna/models/seasonal_ma.py Outdated Show resolved Hide resolved
etna/models/seasonal_ma.py Outdated Show resolved Hide resolved
tests/test_models/test_simple_models.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 13:02 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants