Skip to content

Add refit parameter into backtest #1159

Merged
merged 13 commits into from
Mar 14, 2023
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Mar 9, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1154.

Closing issues

Closes #1154.

@Mr-Geekman Mr-Geekman self-assigned this Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

@github-actions github-actions bot temporarily deployed to pull request March 9, 2023 12:28 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (inference-v2.1@d9c24de). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                Coverage Diff                @@
##             inference-v2.1    #1159   +/-   ##
=================================================
  Coverage                  ?   86.97%           
=================================================
  Files                     ?      164           
  Lines                     ?     9047           
  Branches                  ?        0           
=================================================
  Hits                      ?     7869           
  Misses                    ?     1178           
  Partials                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request March 10, 2023 09:15 Inactive

* If ``True``: pipeline is retrained on each fold.

* If ``False``: pipeline is trained on the first fold, and on future folds trained pipeline is used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "pipeline is trained only on the first fold". I guess it is obvious that it will be used on the other folds

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean without the rest part))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed on a couple of minutes

etna/pipeline/base.py Outdated Show resolved Hide resolved
etna/pipeline/base.py Show resolved Hide resolved
etna/pipeline/base.py Show resolved Hide resolved
etna/pipeline/base.py Show resolved Hide resolved
tests/test_pipeline/test_pipeline.py Outdated Show resolved Hide resolved
tests/test_pipeline/test_pipeline.py Show resolved Hide resolved
tests/test_pipeline/test_pipeline.py Outdated Show resolved Hide resolved
tests/test_pipeline/test_pipeline.py Show resolved Hide resolved
tests/test_pipeline/test_pipeline.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request March 10, 2023 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 13, 2023 10:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 13, 2023 11:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 13, 2023 12:06 Inactive

Raises
------
Exception:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that this is really informative)

@github-actions github-actions bot temporarily deployed to pull request March 14, 2023 07:32 Inactive
@alex-hse-repository alex-hse-repository merged commit 02bf892 into inference-v2.1 Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants