Skip to content

Implement forecast decomposition for Holt-like models #1162

Merged
merged 9 commits into from
Mar 16, 2023
Merged

Implement forecast decomposition for Holt-like models #1162

merged 9 commits into from
Mar 16, 2023

Conversation

brsnw250
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #1146

@brsnw250 brsnw250 self-assigned this Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-1162--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 14, 2023 09:55 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023 •
edited
Loading

Codecov Report

Merging #1162 (92d1dd4) into master (93f8959) will increase coverage by 0.44%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
+ Coverage   86.60%   87.04%   +0.44%     
==========================================
  Files         166      177      +11     
  Lines        9555     9989     +434     
==========================================
+ Hits         8275     8695     +420     
- Misses       1280     1294      +14
Impacted Files Coverage Δ
etna/models/holt_winters.py 99.33% <100.00%> (+0.48%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

alex-hse-repository
alex-hse-repository suggested changes Mar 14, 2023
View reviewed changes
tests/test_models/test_holt_winters_model.py Outdated Show resolved Hide resolved
tests/test_models/test_holt_winters_model.py Outdated Show resolved Hide resolved
tests/test_models/test_holt_winters_model.py Outdated Show resolved Hide resolved
tests/test_models/test_holt_winters_model.py Show resolved Hide resolved
tests/test_models/test_holt_winters_model.py Outdated Show resolved Hide resolved
etna/models/holt_winters.py Outdated Show resolved Hide resolved
etna/models/holt_winters.py Show resolved Hide resolved
etna/models/holt_winters.py Show resolved Hide resolved
etna/models/holt_winters.py Outdated Show resolved Hide resolved
etna/models/holt_winters.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request March 15, 2023 08:54 Inactive
alex-hse-repository
alex-hse-repository suggested changes Mar 15, 2023
View reviewed changes
tests/test_models/test_holt_winters_model.py Show resolved Hide resolved
tests/test_models/test_holt_winters_model.py Outdated Show resolved Hide resolved
etna/models/holt_winters.py Outdated Show resolved Hide resolved
etna/models/holt_winters.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request March 15, 2023 10:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 16, 2023 12:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 16, 2023 12:47 Inactive
@brsnw250 brsnw250 merged commit 2b11e60 into master Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex-hse-repository alex-hse-repository alex-hse-repository approved these changes

Assignees

@brsnw250 brsnw250

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement forecast decomposition for Holt-like models
3 participants
@brsnw250 @codecov-commenter @alex-hse-repository