-
Notifications
You must be signed in to change notification settings - Fork 80
Remove version python-3.7 from pyproject.toml
, update lock
#1183
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1183 +/- ##
===========================================
- Coverage 87.65% 69.13% -18.53%
===========================================
Files 177 177
Lines 10380 10380
===========================================
- Hits 9099 7176 -1923
- Misses 1281 3204 +1923
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🚀 Deployed on https://deploy-preview-1183--etna-docs.netlify.app |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -59,10 +59,12 @@ jobs: | |||
path: .venv | |||
key: venv-${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }} | |||
|
|||
# TODO: remove pip install after optuna fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I write that user should also install the correct version of sqlalchemy? Should't we inform him somehow about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If he has incorrect version he will face some errors working with databases in optuna (it is optuna's problem, not ours).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be obvious that the problem is in sqlalchimy?
Before submitting (must do checklist)
Proposed Changes
pyproject.toml
poetry.lock
poetry.toml
into gitignoreClosing issues