Skip to content

Add default params_to_tune for decomposition transforms #1243

Merged
merged 7 commits into from
May 2, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 25, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1227.

Closing issues

Closes #1227.

@Mr-Geekman Mr-Geekman self-assigned this Apr 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@ee74651). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             automl-2.0    #1243   +/-   ##
=============================================
  Coverage              ?   87.99%           
=============================================
  Files                 ?      177           
  Lines                 ?    10789           
  Branches              ?        0           
=============================================
  Hits                  ?     9494           
  Misses                ?     1295           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Apr 25, 2023

@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 11:08 Inactive
@martins0n martins0n self-requested a review April 26, 2023 07:34
@github-actions github-actions bot temporarily deployed to pull request April 27, 2023 12:34 Inactive
@@ -85,3 +104,30 @@ def __init__(
),
required_features=[in_column],
)

@property
def _is_change_points_model_default(self) -> bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add that case to to_dict. Maybe in another task I guess.

@Mr-Geekman Mr-Geekman merged commit b83e4a9 into automl-2.0 May 2, 2023
@Mr-Geekman Mr-Geekman deleted the issue-1227 branch May 2, 2023 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants