-
Notifications
You must be signed in to change notification settings - Fork 80
Add default params_to_tune
for decomposition transforms
#1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## automl-2.0 #1243 +/- ##
=============================================
Coverage ? 87.99%
=============================================
Files ? 177
Lines ? 10789
Branches ? 0
=============================================
Hits ? 9494
Misses ? 1295
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit 813bcb7.
🚀 Deployed on https://deploy-preview-1243--etna-docs.netlify.app |
Mr-Geekman
commented
Apr 25, 2023
etna/transforms/decomposition/change_points_based/per_interval_models/base.py
Outdated
Show resolved
Hide resolved
Mr-Geekman
commented
Apr 27, 2023
martins0n
reviewed
Apr 27, 2023
etna/transforms/decomposition/change_points_based/per_interval_models/base.py
Outdated
Show resolved
Hide resolved
martins0n
approved these changes
May 2, 2023
martins0n
reviewed
May 2, 2023
@@ -85,3 +104,30 @@ def __init__( | |||
), | |||
required_features=[in_column], | |||
) | |||
|
|||
@property | |||
def _is_change_points_model_default(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add that case to to_dict. Maybe in another task I guess.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #1227.
Closing issues
Closes #1227.