Fix BasePipeline.forecast when prediction intervals are estimated on history data with presence of NaNs
#1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1291--etna-docs.netlify.app |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1291 +/- ##
==========================================
+ Coverage 87.74% 88.08% +0.34%
==========================================
Files 187 187
Lines 10859 10886 +27
==========================================
+ Hits 9528 9589 +61
+ Misses 1331 1297 -34
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Jun 19, 2023
| f"There are NaNs in target on time span from {min_timestamp} to {max_timestamp}. " | ||
| f"It can obstruct prediction interval estimation on history data." | ||
| ) | ||
| if np.any(non_nan_counts < 2): |
There was a problem hiding this comment.
Why is it exactly 2?
There was a problem hiding this comment.
It is the minimal value that can give non-zero result.
alex-hse-repository
approved these changes
Jun 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #899.
Closing issues
Closes #899.