Skip to content

Fix problem with get_anomalies_prediction_interval #1296

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Conversation

ostreech1997
Copy link
Collaborator

@ostreech1997 ostreech1997 commented Jun 22, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #1280.

@ostreech1997 ostreech1997 changed the title Fix problem with 'get_anomalies_prediction_interval` Fix problem with get_anomalies_prediction_interval Jun 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #1296 (199e496) into master (3f4ce91) will decrease coverage by 32.63%.
The diff coverage is 17.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #1296       +/-   ##
===========================================
- Coverage   88.75%   56.12%   -32.63%     
===========================================
  Files         193      193               
  Lines       11743    11746        +3     
===========================================
- Hits        10423     6593     -3830     
- Misses       1320     5153     +3833     
Impacted Files Coverage Δ
.../analysis/outliers/prediction_interval_outliers.py 28.57% <17.64%> (-62.61%) ⬇️

... and 121 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 13:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 13:26 Inactive
Copy link
Contributor

@Mr-Geekman Mr-Geekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at comments above.

@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 06:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 10:42 Inactive
@ostreech1997 ostreech1997 merged commit 72c8aea into master Jun 28, 2023
@ostreech1997 ostreech1997 deleted the issue-1280 branch June 28, 2023 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] get_anomalies_prediction_interval fails when segments have different start dates
3 participants