Skip to content

Add DeseasonalityTransform #1307

Merged
merged 10 commits into from
Jul 6, 2023
Merged

Add DeseasonalityTransform #1307

merged 10 commits into from
Jul 6, 2023

Conversation

ostreech1997
Copy link
Collaborator

@ostreech1997 ostreech1997 commented Jul 4, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #680.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@github-actions github-actions bot temporarily deployed to pull request July 4, 2023 09:27 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #1307 (bbede11) into master (991c648) will increase coverage by 0.01%.
The diff coverage is 91.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
+ Coverage   88.65%   88.66%   +0.01%     
==========================================
  Files         196      197       +1     
  Lines       12048    12127      +79     
==========================================
+ Hits        10681    10753      +72     
- Misses       1367     1374       +7     
Impacted Files Coverage Δ
etna/transforms/decomposition/deseasonal.py 90.90% <90.90%> (ø)
etna/transforms/__init__.py 100.00% <100.00%> (ø)
etna/transforms/decomposition/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

name of processed column
period:
size of seasonality
model:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this by using enum. Value checking will be made there.

etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 14:39 Inactive
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
etna/transforms/decomposition/deseasonal.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 6, 2023 09:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 6, 2023 11:58 Inactive
@ostreech1997 ostreech1997 merged commit e486a24 into master Jul 6, 2023
@ostreech1997 ostreech1997 deleted the issue-680 branch July 6, 2023 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DeseasonalityTransform
3 participants