Add STLTransform
#158
Merged
Add STLTransform
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 8, 2021 12:45
# Conflicts: # etna/transforms/__init__.py
martins0n
reviewed
Oct 8, 2021
etna/transforms/stl.py
Outdated
| stl_kwargs: Optional[Dict[str, Any]] = None, | ||
| ): | ||
| """ | ||
| Init _OneSegmentSTLTransform. |
There was a problem hiding this comment.
Suggested change
| Init _OneSegmentSTLTransform. | |
| Init STLTransform. |
| if isinstance(model, str): | ||
| if model == "arima": | ||
| self.model = ARIMA | ||
| model_kwargs = {"order": (1, 1, 0)} |
There was a problem hiding this comment.
Different default verisions in docstring and this line.
| raise ValueError(f"Not a valid option for model: {model}") | ||
| elif isinstance(model, TimeSeriesModel): | ||
| self.model = model | ||
|
|
There was a problem hiding this comment.
I guess we shoud add else block too
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 87.01% 87.12% +0.11%
==========================================
Files 73 74 +1
Lines 3180 3239 +59
==========================================
+ Hits 2767 2822 +55
- Misses 413 417 +4
Continue to review full report at Codecov.
|
martins0n
previously approved these changes
Oct 11, 2021
martins0n
approved these changes
Oct 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Add
STLTransformclass that subtracts trend and seasonal components.Related Issue
#130.
Closing issues
Closes #130.