Skip to content

Set default value of TSDataset.head method #170

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Oct 11, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Set default value of head method to 5 as it is in pandas.

Related Issue

#145.

Closing issues

Closes #145.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #170 (5609aec) into master (50f2074) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          73       73           
  Lines        3164     3164           
=======================================
  Hits         2765     2765           
  Misses        399      399           
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 86.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f2074...5609aec. Read the comment docs.

@Mr-Geekman Mr-Geekman changed the title Set default value of head method Set default value of TSDataset.head method Oct 11, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review October 11, 2021 08:23
@julia-shenshina julia-shenshina merged commit 9e9e0c4 into master Oct 11, 2021
@iKintosh iKintosh deleted the bug/tsdataset-head-default branch October 15, 2021 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent docs in TSDataset.head
3 participants