Add per-segment regressors length check #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iKintosh
approved these changes
Sep 9, 2021
Comment on lines
+143
to
+147
| raise ValueError( | ||
| f"All the regressor series should start not later than corresponding 'target'." | ||
| f"Series {series} of segment {segment} have not enough history: " | ||
| f"{target.index.min()} < {exog_series.index.min()}." | ||
| ) |
There was a problem hiding this comment.
This way we won't show all problematic segments. It is not huge problem right now, but for convenience I'd like to see all segments contain this problem
Mr-Geekman
approved these changes
Sep 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.