-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 86.66% 87.19% +0.53%
==========================================
Files 92 92
Lines 4461 4522 +61
==========================================
+ Hits 3866 3943 +77
+ Misses 595 579 -16
Continue to review full report at Codecov.
|
Mr-Geekman
reviewed
Nov 9, 2021
|
||
metric = MAE(mode="macro") | ||
|
||
assert metric(pred_mean_segment_encoding, test) < 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use R2 here, it is more intuitive in sense of good/bad result. May be noise should be smaller.
Mr-Geekman
approved these changes
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Add MeanSegmentEncoderTransform
Related Issue
Closing issues
closes #233