ETNA-759: MedianOutliersTransform and DensityOutliersTransform
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 13, 2021 11:35
Mr-Geekman
commented
Sep 13, 2021
etna/transforms/outliers.py
Outdated
| dataframe with in_column series with filled with NaNs | ||
| """ | ||
| result_df = df.copy() | ||
| for segment in df.columns.get_level_values("segment"): |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage ? 90.28%
=========================================
Files ? 45
Lines ? 1966
Branches ? 0
=========================================
Hits ? 1775
Misses ? 191
Partials ? 0 Continue to review full report at Codecov.
|
iKintosh
reviewed
Sep 13, 2021
etna/transforms/outliers.py
Outdated
| dict of outliers: | ||
| dict of outliers in format {segment: [outliers_timestamps]} | ||
| """ | ||
| from etna.analysis import get_anomalies_median |
There was a problem hiding this comment.
Do we need to use both: type_checking and importing inside methods?
iKintosh
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New classes to work with outliers were added.