Skip to content

Spell checking during build #269 #303

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Spell checking during build #269 #303

merged 3 commits into from
Nov 22, 2021

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Nov 19, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #269

@martins0n
Copy link
Contributor Author

Codespell mostly detects typical misspellings not errors.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #303 (243e92d) into master (18cb14e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          95       95           
  Lines        4683     4683           
=======================================
  Hits         4104     4104           
  Misses        579      579           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18cb14e...243e92d. Read the comment docs.

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@martins0n martins0n merged commit 2e2c006 into master Nov 22, 2021
@martins0n martins0n deleted the issue-269 branch November 22, 2021 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spell checking during build
3 participants