Skip to content

Replace setting columns with join in SegmentEncoder #331

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Nov 29, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

#323.

Related Issue

#323.

Closing issues

Closes #323.

@Mr-Geekman Mr-Geekman self-assigned this Nov 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #331 (cb59f05) into master (96b3666) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   87.66%   87.66%   -0.01%     
==========================================
  Files          98       98              
  Lines        4817     4816       -1     
==========================================
- Hits         4223     4222       -1     
  Misses        594      594              
Impacted Files Coverage Δ
etna/transforms/segment_encoder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b3666...cb59f05. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review November 29, 2021 15:49
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add test here that it encodes segments correctly

@martins0n martins0n merged commit af51f3e into master Dec 1, 2021
@iKintosh iKintosh deleted the issue-323 branch December 9, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegmentEncoderTransform.transform perfomance issue
4 participants