Skip to content

remove tscv #337

Merged
merged 3 commits into from
Dec 2, 2021
Merged

remove tscv #337

merged 3 commits into from
Dec 2, 2021

Conversation

iKintosh
Copy link
Contributor

@iKintosh iKintosh commented Nov 30, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

Closes #294

@iKintosh iKintosh self-assigned this Nov 30, 2021
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update please

  • example notebook markdowns and table of content
  • remove tests/test_model_selection/test_... because we don't have model selection module anymore

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #337 (6fef012) into master (ee5b747) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   87.70%   87.41%   -0.29%     
==========================================
  Files          98       96       -2     
  Lines        4830     4696     -134     
==========================================
- Hits         4236     4105     -131     
+ Misses        594      591       -3     
Impacted Files Coverage Δ
etna/models/sklearn.py 95.74% <0.00%> (-0.56%) ⬇️
etna/models/catboost.py 100.00% <0.00%> (ø)
etna/analysis/__init__.py 100.00% <0.00%> (ø)
etna/analysis/outliers/__init__.py 100.00% <0.00%> (ø)
etna/transforms/segment_encoder.py 100.00% <0.00%> (ø)
etna/pipeline/pipeline.py 99.45% <0.00%> (+0.01%) ⬆️
etna/transforms/outliers.py 98.82% <0.00%> (+0.01%) ⬆️
etna/analysis/outliers/density_outliers.py 97.82% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5b747...6fef012. Read the comment docs.

@julia-shenshina julia-shenshina merged commit adcbae8 into master Dec 2, 2021
@iKintosh iKintosh deleted the chore/removeTSCV branch December 9, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete TimeSeriesCrossValidation 💥
3 participants