-
Notifications
You must be signed in to change notification settings - Fork 80
Add TSDatasets.__init__
regressors logic
#357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iKintosh
reviewed
Dec 6, 2021
etna/datasets/tsdataset.py
Outdated
else: | ||
return sorted(list(known_future_unique)) | ||
elif len(known_future) > 0: | ||
raise ValueError("There are is exogenous data to extract known future features") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
iKintosh
reviewed
Dec 6, 2021
It was decided to add |
iKintosh
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## breaking_change/regressors #357 +/- ##
==============================================================
+ Coverage 87.37% 87.39% +0.02%
==============================================================
Files 96 96
Lines 4697 4706 +9
==============================================================
+ Hits 4104 4113 +9
Misses 593 593
Continue to review full report at Codecov.
|
iKintosh
approved these changes
Dec 8, 2021
1 task
alex-hse-repository
pushed a commit
that referenced
this pull request
Jan 31, 2022
alex-hse-repository
pushed a commit
that referenced
this pull request
Feb 1, 2022
alex-hse-repository
pushed a commit
that referenced
this pull request
Feb 8, 2022
alex-hse-repository
pushed a commit
that referenced
this pull request
Feb 14, 2022
alex-hse-repository
pushed a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #327.
Related Issue
#327.
Closing issues
Closes #327.