Skip to content

Sarimax bug in future prediction with quantiles #391

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Dec 17, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #375

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #391 (9cfd839) into master (08b0f81) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files          98       98           
  Lines        4964     4964           
=======================================
  Hits         4320     4320           
  Misses        644      644           
Impacted Files Coverage Δ
etna/models/sarimax.py 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b0f81...9cfd839. Read the comment docs.

@martins0n martins0n changed the title FIX: sarimax bug in future prediction Sarimax bug in future prediction with quantiles Dec 17, 2021
@martins0n martins0n merged commit a39fdd5 into master Dec 17, 2021
@martins0n martins0n deleted the issue-375 branch December 17, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] nan in target for forecasting with prediction intervals for SARIMAX
3 participants