Skip to content

[BUG] inverse transform doesn't affect quantiles #395

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Dec 20, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #376

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #395 (87a3004) into master (e884f8a) will decrease coverage by 34.29%.
The diff coverage is 18.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #395       +/-   ##
===========================================
- Coverage   87.02%   52.73%   -34.30%     
===========================================
  Files          98       99        +1     
  Lines        4964     5014       +50     
===========================================
- Hits         4320     2644     -1676     
- Misses        644     2370     +1726     
Impacted Files Coverage Δ
etna/transforms/sklearn.py 29.03% <9.09%> (-66.75%) ⬇️
etna/transforms/add_constant.py 61.90% <20.00%> (-35.40%) ⬇️
etna/transforms/change_points_trend.py 40.95% <20.00%> (-58.05%) ⬇️
etna/transforms/detrend.py 41.66% <20.00%> (-56.52%) ⬇️
etna/transforms/log.py 60.86% <20.00%> (-36.70%) ⬇️
etna/transforms/stl.py 61.19% <20.00%> (-32.36%) ⬇️
etna/transforms/utils.py 66.66% <66.66%> (ø)
etna/commands/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
etna/commands/backtest_command.py 0.00% <0.00%> (-96.43%) ⬇️
etna/commands/forecast_command.py 0.00% <0.00%> (-92.00%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e884f8a...87a3004. Read the comment docs.

@julia-shenshina julia-shenshina merged commit 4d67c83 into master Dec 22, 2021
@martins0n martins0n deleted the issue-376 branch December 22, 2021 11:41
martins0n added a commit that referenced this pull request Dec 23, 2021
* [BUG] inverse transform doesn't affect quantiles

* FIX: changelog

* FIX: add re

* FIX: lint

* FIX: match pattern in test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] inverse transform doesn't affect quantiles
3 participants