Fix bug with column names in SklearnTransform
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 21, 2021 10:26
… tests on transforms
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 87.02% 87.09% +0.07%
==========================================
Files 98 98
Lines 4964 4945 -19
==========================================
- Hits 4320 4307 -13
+ Misses 644 638 -6
Continue to review full report at Codecov.
|
added 6 commits
December 21, 2021 11:05
# Conflicts: # CHANGELOG.md
…n, remove regressor prefix in name generation
# Conflicts: # CHANGELOG.md
alex-hse-repository
suggested changes
Dec 22, 2021
| for i, column in enumerate(in_column): | ||
| # find relevant column name in transformed_df | ||
| column_multi = [x for x in new_columns if column in x][0] | ||
| column_multi = {key: value for key, value in zip(transform.in_column, transform.out_columns)}[column] |
There was a problem hiding this comment.
May be it is better to place it out of cicle
alex-hse-repository
approved these changes
Dec 22, 2021
martins0n
pushed a commit
that referenced
this pull request
Dec 23, 2021
Fix bug with column names in `SklearnTransform`
alex-hse-repository
added a commit
that referenced
this pull request
Dec 24, 2021
Fix bug with column names in `SklearnTransform`
1 task
alex-hse-repository
added a commit
that referenced
this pull request
Dec 28, 2021
Fix bug with column names in `SklearnTransform`
alex-hse-repository
added a commit
that referenced
this pull request
Dec 28, 2021
* Merge pull request #398 from tinkoff-ai/issue-377 Fix bug with column names in `SklearnTransform` * Add missing import
alex-hse-repository
added a commit
that referenced
this pull request
Jan 31, 2022
* Merge pull request #398 from tinkoff-ai/issue-377 Fix bug with column names in `SklearnTransform` * Add missing import
alex-hse-repository
added a commit
that referenced
this pull request
Feb 8, 2022
* Merge pull request #398 from tinkoff-ai/issue-377 Fix bug with column names in `SklearnTransform` * Add missing import
alex-hse-repository
added a commit
that referenced
this pull request
Feb 14, 2022
* Merge pull request #398 from tinkoff-ai/issue-377 Fix bug with column names in `SklearnTransform` * Add missing import
alex-hse-repository
added a commit
that referenced
this pull request
Feb 15, 2022
* Merge pull request #398 from tinkoff-ai/issue-377 Fix bug with column names in `SklearnTransform` * Add missing import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
#377
Closing issues
Closes #377