Skip to content

fix Gale-Shapley bug #410

Merged
merged 9 commits into from
Dec 28, 2021
Merged

fix Gale-Shapley bug #410

merged 9 commits into from
Dec 28, 2021

Conversation

Ama16
Copy link
Contributor

@Ama16 Ama16 commented Dec 22, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#404

Closing issues

Closes #404

@Ama16 Ama16 linked an issue Dec 22, 2021 that may be closed by this pull request
1 task
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #410 (bbd6d6a) into master (00b20e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files          99       99           
  Lines        5002     5003    +1     
=======================================
+ Hits         4363     4364    +1     
  Misses        639      639           
Impacted Files Coverage Δ
etna/transforms/gale_shapley.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b20e5...bbd6d6a. Read the comment docs.

Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upd CHANGELOG please

@julia-shenshina julia-shenshina merged commit ecf872d into master Dec 28, 2021
@martins0n martins0n deleted the issue-404 branch January 21, 2022 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GaleShapleyFeatureSelectionTransform without **relevance_params
3 participants