Skip to content

Add warning section about look-ahead bias #464

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Add warning section about look-ahead bias #464

merged 6 commits into from
Jan 26, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jan 26, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #390

Related Issue

#390

Closing issues

Close #390

@Mr-Geekman Mr-Geekman self-assigned this Jan 26, 2022
@Mr-Geekman
Copy link
Contributor Author

That is how it looks in the docs:
Example in the docs

@Mr-Geekman Mr-Geekman changed the title Add warning about look-ahead bias Add warning section about look-ahead bias Jan 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #464 (6a6cf6c) into master (70c5fac) will decrease coverage by 34.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #464       +/-   ##
===========================================
- Coverage   87.98%   53.64%   -34.34%     
===========================================
  Files         115      115               
  Lines        5441     5441               
===========================================
- Hits         4787     2919     -1868     
- Misses        654     2522     +1868     
Impacted Files Coverage Δ
etna/transforms/decomposition/binseg.py 100.00% <ø> (ø)
...na/transforms/decomposition/change_points_trend.py 40.18% <ø> (-58.88%) ⬇️
etna/transforms/decomposition/detrend.py 41.66% <ø> (-56.67%) ⬇️
etna/transforms/decomposition/stl.py 58.57% <ø> (-35.72%) ⬇️
etna/transforms/decomposition/trend.py 45.94% <ø> (-54.06%) ⬇️
etna/transforms/math/power.py 100.00% <ø> (ø)
etna/transforms/math/scalers.py 100.00% <ø> (ø)
etna/transforms/missing_values/imputation.py 34.48% <ø> (-65.52%) ⬇️
etna/transforms/missing_values/resample.py 24.13% <ø> (-68.97%) ⬇️
etna/transforms/outliers/point_outliers.py 92.68% <ø> (-7.32%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c5fac...6a6cf6c. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review January 26, 2022 13:59
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit e925d3d into master Jan 26, 2022
@martins0n martins0n deleted the issue-390 branch January 26, 2022 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning about look-ahead bias for transforms
3 participants