Skip to content

Change np.percentile to np.nanpercentile in loggers.base #483

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Feb 2, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

#482.

Related Issue

#482.

Closing issues

Closes #482.

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Feb 2, 2022
@Mr-Geekman Mr-Geekman self-assigned this Feb 2, 2022
@Mr-Geekman Mr-Geekman marked this pull request as ready for review February 2, 2022 15:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #483 (1a329a4) into master (c1f49ed) will decrease coverage by 34.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #483       +/-   ##
===========================================
- Coverage   87.83%   53.55%   -34.29%     
===========================================
  Files         115      115               
  Lines        5452     5452               
===========================================
- Hits         4789     2920     -1869     
- Misses        663     2532     +1869     
Impacted Files Coverage Δ
etna/loggers/base.py 67.60% <0.00%> (-28.17%) ⬇️
etna/commands/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
etna/commands/backtest_command.py 0.00% <0.00%> (-96.43%) ⬇️
etna/commands/forecast_command.py 0.00% <0.00%> (-92.00%) ⬇️
etna/commands/__main__.py 0.00% <0.00%> (-87.50%) ⬇️
etna/commands/resolvers.py 0.00% <0.00%> (-80.00%) ⬇️
etna/analysis/outliers/density_outliers.py 22.44% <0.00%> (-75.52%) ⬇️
etna/transforms/timestamp/time_flags.py 26.02% <0.00%> (-73.98%) ⬇️
etna/transforms/timestamp/fourier.py 27.08% <0.00%> (-72.92%) ⬇️
etna/transforms/feature_selection/filter.py 28.57% <0.00%> (-71.43%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f49ed...1a329a4. Read the comment docs.

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes life easier. Thanks!

@iKintosh iKintosh enabled auto-merge (squash) February 2, 2022 15:37
@iKintosh iKintosh merged commit 2ebfbd8 into master Feb 2, 2022
@iKintosh iKintosh deleted the issue-482 branch March 22, 2022 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make percentile in loggers be able to work with NaNs
3 participants