Add find_change_points and tests for it
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2022 18:52
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 87.99% 88.03% +0.03%
==========================================
Files 116 118 +2
Lines 5538 5556 +18
==========================================
+ Hits 4873 4891 +18
Misses 665 665
Continue to review full report at Codecov.
|
alex-hse-repository
suggested changes
Feb 14, 2022
| series: pd.Series, change_point_model: BaseEstimator, **model_predict_params | ||
| ) -> List[pd.Timestamp]: | ||
| """Find change trend points within one segment.""" | ||
| signal = _prepare_signal(series=series, model=change_point_model) |
There was a problem hiding this comment.
Make the order of parameters consistent with the order of parameters in signature(or vice versa)
| def find_change_points( | ||
| ts: TSDataset, in_column: str, change_point_model: BaseEstimator, **model_predict_params | ||
| ) -> Dict[str, List[pd.Timestamp]]: | ||
| """Find change trend points using ruptures models. |
There was a problem hiding this comment.
May be "change trend points" -> "trend change points"
| Returns | ||
| ------- | ||
| result: | ||
| dictionary with list of change trend points for each segment |
There was a problem hiding this comment.
May be "change trend points" -> "trend change points"
…> trend change points
alex-hse-repository
approved these changes
Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #485.
Related Issue
#485.
Closing issues
Closes #485.