Skip to content

Add table option to ConsoleLogger #544

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Add table option to ConsoleLogger #544

merged 4 commits into from
Feb 18, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Feb 18, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #542.

Related Issue

#542.

Closing issues

Closes #542.

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Feb 18, 2022
@Mr-Geekman Mr-Geekman self-assigned this Feb 18, 2022
@Mr-Geekman Mr-Geekman changed the title Add table option to ConsoleLogger Add table option to ConsoleLogger Feb 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #544 (112552e) into master (2242d40) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   87.26%   87.27%           
=======================================
  Files         118      118           
  Lines        5788     5792    +4     
=======================================
+ Hits         5051     5055    +4     
  Misses        737      737           
Impacted Files Coverage Δ
etna/loggers/console_logger.py 90.90% <92.30%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2242d40...112552e. Read the comment docs.

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n enabled auto-merge (squash) February 18, 2022 15:39
@martins0n martins0n merged commit f77c56d into master Feb 18, 2022
@iKintosh iKintosh deleted the issue-542 branch March 22, 2022 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table option to ConsoleLogger
3 participants