Skip to content

Add missing documentation #55

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Add missing documentation #55

merged 1 commit into from
Sep 16, 2021

Conversation

Mr-Geekman
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? make lint (poetry install -E style).
  • Did you make sure to update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest tests/ ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#54.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

Closes #54.

@Mr-Geekman Mr-Geekman added the documentation Improvements or additions to documentation label Sep 15, 2021
@Mr-Geekman Mr-Geekman self-assigned this Sep 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #55 (34fca22) into master (26d88da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          45       45           
  Lines        1976     1976           
=======================================
  Hits         1785     1785           
  Misses        191      191           
Impacted Files Coverage Δ
etna/models/catboost.py 100.00% <ø> (ø)
etna/models/sklearn.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d88da...34fca22. Read the comment docs.

@martins0n martins0n merged commit 2df0793 into master Sep 16, 2021
@martins0n martins0n deleted the issue-54 branch September 16, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models missing documentation
3 participants