-
Notifications
You must be signed in to change notification settings - Fork 80
Update get_started section in README #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Geekman
changed the title
Add new get_started in README, add blank lines for consistency
Add new get_started in README
Feb 22, 2022
Mr-Geekman
changed the title
Add new get_started in README
Update get_started section in README
Feb 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
=======================================
Coverage 86.80% 86.80%
=======================================
Files 119 119
Lines 5739 5739
=======================================
Hits 4982 4982
Misses 757 757 Continue to review full report at Codecov.
|
iKintosh
reviewed
Feb 24, 2022
iKintosh
suggested changes
Mar 1, 2022
README.md
Outdated
Comment on lines
108
to
114
from etna.transforms import DateFlagsTransform | ||
from etna.transforms import DensityOutliersTransform | ||
from etna.transforms import FourierTransform | ||
from etna.transforms import LagTransform | ||
from etna.transforms import LinearTrendTransform | ||
from etna.transforms import SegmentEncoderTransform | ||
from etna.transforms import TimeSeriesImputerTransform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
from etna.transforms import DateFlagsTransform | |
from etna.transforms import DensityOutliersTransform | |
from etna.transforms import FourierTransform | |
from etna.transforms import LagTransform | |
from etna.transforms import LinearTrendTransform | |
from etna.transforms import SegmentEncoderTransform | |
from etna.transforms import TimeSeriesImputerTransform | |
from etna.transforms import DateFlagsTransform, DensityOutliersTransform, FourierTransform, LagTransform, \ | |
LinearTrendTransform, SegmentEncoderTransform, TimeSeriesImputerTransform |
README.md
Outdated
Comment on lines
122
to
128
DateFlagsTransform( | ||
day_number_in_week=True, | ||
day_number_in_month=True, | ||
is_weekend=True, | ||
week_number_in_month=True, | ||
out_column="date_flag", | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
DateFlagsTransform( | |
day_number_in_week=True, | |
day_number_in_month=True, | |
is_weekend=True, | |
week_number_in_month=True, | |
out_column="date_flag", | |
), | |
DateFlagsTransform(is_weekend=True, week_number_in_month=True, out_column="date_flag"), |
iKintosh
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #491.
Related Issue
#491.
Closing issues
Closes #491.