Skip to content

Fix that segment is string #602

Merged
merged 8 commits into from
Mar 16, 2022
Merged

Fix that segment is string #602

merged 8 commits into from
Mar 16, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Mar 15, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #568.

Related Issue

#568.

Closing issues

Closes #568.

@Mr-Geekman Mr-Geekman added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 15, 2022
@Mr-Geekman Mr-Geekman self-assigned this Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #602 (54c2d05) into master (a321f5a) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   85.35%   85.15%   -0.20%     
==========================================
  Files         117      117              
  Lines        5789     5813      +24     
==========================================
+ Hits         4941     4950       +9     
- Misses        848      863      +15     
Impacted Files Coverage Δ
etna/analysis/eda_utils.py 18.51% <ø> (-0.60%) ⬇️
etna/datasets/tsdataset.py 90.05% <100.00%> (+0.22%) ⬆️
etna/analysis/plotters.py 16.35% <0.00%> (-0.45%) ⬇️
etna/analysis/__init__.py 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@martins0n martins0n requested a review from Ama16 March 16, 2022 07:47
@Mr-Geekman Mr-Geekman merged commit 1ec52f2 into master Mar 16, 2022
@Mr-Geekman Mr-Geekman deleted the issue-568 branch March 16, 2022 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix that segment is string
3 participants