-
Notifications
You must be signed in to change notification settings - Fork 80
Fix SARIMAX bug #637
Merged
Fix SARIMAX bug #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://deploy-preview-637--etna-docs.netlify.app |
martins0n
suggested changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add changes to changelog
model = SARIMAXModel() | ||
model.fit(example_tsds) | ||
future_ts = example_tsds.make_future(future_steps=1) | ||
_ = model.forecast(future_ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add minimal asserts - for length for example?
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 118 118
Lines 6245 6247 +2
=======================================
+ Hits 5264 5266 +2
Misses 981 981
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
martins0n
approved these changes
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
#583
Closing issues
Closes #583.