Skip to content

Fix SARIMAX bug #637

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Fix SARIMAX bug #637

merged 4 commits into from
Apr 7, 2022

Conversation

Ama16
Copy link
Contributor

@Ama16 Ama16 commented Apr 7, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#583

Closing issues

Closes #583.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

🚀 Deployed on https://deploy-preview-637--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 7, 2022 10:00 Inactive
@Ama16 Ama16 requested a review from martins0n April 7, 2022 10:18
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add changes to changelog

model = SARIMAXModel()
model.fit(example_tsds)
future_ts = example_tsds.make_future(future_steps=1)
_ = model.forecast(future_ts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add minimal asserts - for length for example?

@github-actions github-actions bot temporarily deployed to pull request April 7, 2022 11:23 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #637 (c68fc34) into master (76d1e99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files         118      118           
  Lines        6245     6247    +2     
=======================================
+ Hits         5264     5266    +2     
  Misses        981      981           
Impacted Files Coverage Δ
etna/models/sarimax.py 94.11% <100.00%> (+0.10%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@martins0n martins0n merged commit 1b12a3b into master Apr 7, 2022
@martins0n martins0n deleted the issue-583 branch April 7, 2022 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SARIMAX can't predict interval if horizon=1
3 participants