Skip to content

Change default aggregation method in metric #684

Merged
merged 2 commits into from
May 11, 2022

Conversation

Ama16
Copy link
Contributor

@Ama16 Ama16 commented May 11, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@github-actions
Copy link

github-actions bot commented May 11, 2022

🚀 Deployed on https://deploy-preview-684--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 11, 2022 14:22 Inactive
@julia-shenshina julia-shenshina self-requested a review May 11, 2022 14:24
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #684 (f739c4f) into master (4c04584) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   83.82%   83.83%           
=======================================
  Files         119      119           
  Lines        6400     6401    +1     
=======================================
+ Hits         5365     5366    +1     
  Misses       1035     1035           
Impacted Files Coverage Δ
etna/metrics/base.py 96.87% <100.00%> (+0.04%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request May 11, 2022 14:55 Inactive
@julia-shenshina julia-shenshina merged commit 672a60a into master May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants