FIX: deepcopy for fitted deepmodel #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-735--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 83.67% 83.57% -0.11%
==========================================
Files 120 121 +1
Lines 6629 6643 +14
==========================================
+ Hits 5547 5552 +5
- Misses 1082 1091 +9
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Mr-Geekman
reviewed
Jun 7, 2022
Mr-Geekman
reviewed
Jun 7, 2022
etna/models/nn/utils.py
Outdated
| """Mixin for `__deepcopy__` behaviour overriding.""" | ||
|
|
||
| def __deepcopy__(self, memo): | ||
| """Drop `model` and `trainer` attributes while deepcopy.""" |
There was a problem hiding this comment.
Same about variable names.
Mr-Geekman
reviewed
Jun 7, 2022
etna/models/nn/utils.py
Outdated
|
|
||
|
|
||
| class _DeepCopyMixin: | ||
| """Mixin for `__deepcopy__` behaviour overriding.""" |
There was a problem hiding this comment.
Variable names should be surrounded by two surrounding characters instead of one.
Otherwise in ReST it will be italic instead of monotype.
There was a problem hiding this comment.
Everything else is fine.
Mr-Geekman
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
I propose deepcopy behaviour changes for deep models: we dont copy model and trainer attributes
Reason:
"(graph leaves) support the deepcopy protocol at the moment")
Related Issue
Closing issues