Skip to content

Fix append FutureWarning #764

Merged
merged 9 commits into from
Jun 23, 2022
Merged

Fix append FutureWarning #764

merged 9 commits into from
Jun 23, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Jun 21, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #751

@github-actions
Copy link

github-actions bot commented Jun 21, 2022

🚀 Deployed on https://deploy-preview-764--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 21, 2022 07:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 21, 2022 07:55 Inactive
@alex-hse-repository alex-hse-repository self-assigned this Jun 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #764 (83e1eb1) into master (2b86768) will increase coverage by 33.84%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           master     #764       +/-   ##
===========================================
+ Coverage   49.88%   83.72%   +33.84%     
===========================================
  Files         122      122               
  Lines        6776     6778        +2     
===========================================
+ Hits         3380     5675     +2295     
+ Misses       3396     1103     -2293     
Impacted Files Coverage Δ
etna/analysis/plotters.py 26.06% <0.00%> (+14.93%) ⬆️
etna/analysis/eda_utils.py 53.06% <100.00%> (+33.43%) ⬆️
etna/pipeline/base.py 94.50% <100.00%> (+9.92%) ⬆️
etna/models/nn/tft.py 100.00% <0.00%> (+3.22%) ⬆️
etna/metrics/base.py 96.87% <0.00%> (+4.68%) ⬆️
etna/models/seasonal_ma.py 97.36% <0.00%> (+5.26%) ⬆️
etna/models/prophet.py 98.80% <0.00%> (+7.14%) ⬆️
etna/transforms/outliers/point_outliers.py 100.00% <0.00%> (+7.31%) ⬆️
etna/ensembles/base.py 100.00% <0.00%> (+7.40%) ⬆️
etna/pipeline/pipeline.py 96.96% <0.00%> (+9.09%) ⬆️
... and 74 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request June 21, 2022 08:29 Inactive
@martins0n
Copy link
Contributor

Let's fix this in tests too. We have the same issue with fixtures

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have multiple issues with fixtures

@github-actions github-actions bot temporarily deployed to pull request June 22, 2022 11:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2022 05:02 Inactive
@martins0n martins0n enabled auto-merge (squash) June 23, 2022 06:58
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot temporarily deployed to pull request June 23, 2022 07:02 Inactive
@martins0n martins0n merged commit e3445c9 into master Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FutureWarning: The frame.append method is deprecated. Use pandas.concat instead.
3 participants