[BUG] Raise errors in models.nn if they can't make in-sample and some cases out-sample predictions #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple predictions correclty Fixes #787
|
🚀 Deployed on https://deploy-preview-813--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
+ Coverage 84.05% 84.07% +0.02%
==========================================
Files 126 126
Lines 7220 7236 +16
==========================================
+ Hits 6069 6084 +15
- Misses 1151 1152 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Mr-Geekman
reviewed
Jul 22, 2022
Mr-Geekman
reviewed
Jul 22, 2022
| "You can only forecast from the next point after the last one in the training dataset: " | ||
| f"last train timestamp: {self._last_train_timestamp}, first test timestamp is {ts.index[0]}" | ||
| ) | ||
| else: |
There was a problem hiding this comment.
Do we need this else block?
There was a problem hiding this comment.
I'd like to have all possible switches explicitly
Mr-Geekman
suggested changes
Jul 22, 2022
Mr-Geekman
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #787